| Age | Commit message (Collapse) | Author |
|---|
|
I see no need in verifying the status code.
It's enough to just get the error.
|
|
The main point is that from now on, tests are required to add
new features. If the fix is minor enough, not having a test
is probably alright.
That distinction is not represented in the contribution guide
as more tests are better - people should prefer to have a test
whenever they contribute anything.
My motivation to finally do this is the sad realization that
I grow too unconfident about the quality of some contributions
without having tests that proof they are valid. It's not enough
to not break anything that exists, as the current test-suite is
certainly not perfect either.
|
|
Just went through all changes and adjusted them to the best of my
abilities. As there are no tests to claim otherwise, I believe
this is correct enough.
However, it becomes evident that it's no longer possible to just
make changes without backing them with a respective test.
|
|
https://github.com/barry-scott/GitPython into barry-scott-pr-cmd-raise-with-stderr-on-error
|
|
This issue must have rosen from `to_progress_instance()`
being inserted in a spot where `None` was a legit value.
Fixes #462
|
|
Convert to the expected bytes.
|
|
|
|
pr-cmd-raise-with-stderr-on-error
|
|
Make sure os is not even partly destroyed
|
|
|
|
|
|
Fixes #457: 'TypeError: decode() takes no keyword arguments' on Python 2.6
|
|
|
|
Please exclude the particular assertion instead.
Related to
https://github.com/gitpython-developers/GitPython/commit/a3f24f64a20d1e09917288f67fd21969f4444acd#commitcomment-17691581
|
|
More information in the respective issue.
Fixes #453
|
|
|
|
|
|
This catches the case where the matched line contains "(" or ")"
characters.
|
|
|
|
|
|
gitpython-developers/fix-for-invalid-data-in-commits
Add test case as example of Git commit with invalid data
|
|
gitpython-developers/fix-octal-escaped-path-parser-bug
Fix bug in diff parser output
|
|
remove stderr for a wait() that is not the GitPython wrapper.
|
|
Previously, GitPython chokes on this while decoding. Rather than
choking, instead accept the error and replace the invalid bytes by the
� (\x80) char.
|
|
Skip test that always fails on Travis CI
|
|
This is a real commit from the microjs.com open source project, see
https://github.com/madrobby/microjs.com/commit/7e8457c17850d0991763941213dcb403d80f39f8,
which is declared to be encoded in UTF-8, but contains invalid bytes.
This makes GitPython choke on it while decoding. Rather than choking,
this should instead accept the error and replace the invalid bytes by
the � (\x80) char.
|
|
|
|
|
|
The diff --patch parser was missing some edge case where Git would
encode non-ASCII chars in path names as octals, but these weren't
decoded properly.
\360\237\222\251.txt
Decoded via utf-8, that will return:
💩.txt
|
|
|
|
|
|
Python :) !!
Related to #451
|
|
Related to #451
Signed-off-by: Sebastian Thiel <byronimo@gmail.com>
|
|
Fix traceback because _seen_ops is not initialised
|
|
must call the base class __init__
|
|
Make version check much more readable, and fix it at
the same time. The previous implementation would assume
progress is supported just by looking at the patch-level
for instance.
A quick check of the git sources seems to indicate the
--progress flag exists in v1.7 of the git command-line
already.
Fixes #449
|
|
That way, the base type doesn't need any adjustment.
Related to #450
|
|
Related to #450
|
|
Minor adjustments to PR to match current code style.
Related to #450
|
|
The progress arg to push, pull, fetch and clone is now a python calla…
|
|
|
|
This simplifies the API and removes the parser, RemoteProgres,
from the API as RemoteProgress is an internal detail of the implementation.
progress is accepted as:
* None - drop progress messages
* callable (function etc) - call the function with the same args as update
* object - assume its RemoteProgress derived as use as before
RemoteProgress takes an optional progress_function argument.
It will call the progress function if not None otherwise call self.update
as it used to.
|
|
Use proper syntax for conditional expressions.
|
|
Changing warning to debug logging, to avoid warning showing off when nothing's wrong
|
|
(instead of abusing the "short-circuit" property of logical operations)
|
|
nothing's wrong
cf #444
Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
|
|
Related to #444
|
|
|
|
That way, real-time parsing of output should finally be possible.
Related to #444
|
|
That way, progress usage will behave as expected.
Fixes #444
|
