| Age | Commit message (Collapse) | Author |
|---|
|
Fixes #430
|
|
Issue #407
|
|
|
|
This issue only surfaced in python 2, in case paths containing unicode
characters were not actual unicode objects.
In python 3, this was never the issue.
Closes #331
|
|
It was a left-over of some prior hacking that was not removed by
accident.
|
|
* untracked_files could, if there were spaces in the path returned,
re-rencode the previously decoded unicode string thanks to a
`decode("string_escape")` call. Now re-encode into utf-8 afterwards
- added test to assure this works indeed
* IndexFile.add() didn't handle unicode correctly and would write
broken index files. The solution was to compute the path length after
encoding it into utf-8 bytes, not before ... .
Closes #320
|
|
|
|
|
|
When expanding directories, check if it is a symlink and don't expand
them at all.
Previously, we followed symlinks and expanded their contents, which
could lead to weird index files.
Fixes #302
|
|
This should prevent a resource warning given in py3
Fixes #263
|
|
It turned out that the index is not actually corrupted, which is good
news. What happens is that `git` writes `TREE` extension data into the
index, which causes it to write out the given tree *as is* next time
a `git commit` is executed. When using `git add`, this extension data
is maintained automatically. However, GitPython doesn't do that ... .
Usually this is no problem at all, as you are supposed to use
`IndexFile.commit(...)` along with `IndexFile.add(...)`.
Thanks to a shortcoming in the GitPython API, the index was
automatically written out whenever files have been added, without
providing control over whether or not *extension data* will be
written along with it.
My fix consists of an additional flag in `IndexFile.add(...)`, which
causes extension data not to be written by default, so commits can be
safely done via `git commit` or `IndexFile.commit(...)`.
However, this might introduce new subtle bugs in case someone is
relying on extension data to be written. As this can be controlled
through the said flag though, a fix is easily done in that case.
Fixes #265
|
|
Related to #224
[ci skip]
|
|
https://github.com/yarikoptic/GitPython into yarikoptic-bf/run_hooks_from_working_dir
|
|
Latest version of it is required to show the issues travis shows as well
|
|
Otherwise commit hook might rightfully fail, as happens if
repository is e.g. git-annex repository. See e.g. now failing
https://travis-ci.org/datalad/datalad/builds/49802394\#L1590
which seems to pass tests nicely with patch as this
|
|
That way they are protected from regression.
Fixes #239
|
|
Previously, it checked for AssertionErrors, now we have to implement
need-unbare-repo check ourselves.
|
|
Fixes #7
[ci skip]
|
|
However, it does so only on posix. The test-case will run on posix only
as well.
Please note that in theory, even on windows we will attempt to run hooks,
even though I am not sure that this will actually work.
Fixes #81
|
|
used consistently.
This will save IOPs, and make the code easier to understand (I suppose).
Related to #224
|
|
required afterall.
Turns out that the now removed `read_gitfile` functions applied os.path.realpath which caused
the issue described in #224.
Fixes #224
|
|
index related work.
That way, we don't try to compare a real-path to a non-real one, which would make the implementation think
a file is not actually part of the repository.
Fixes #224
|
|
Next up is using threads
|
|
|
|
|
|
Now it's about going through PY3 issues
|
|
However, StringIO really is ByteIO in most cases, and py2.7 should
run but doesn't.
This should be made work first.
|
|
More to come, especially when it's about strings
|
|
|
|
There is more work to do though, as many imports are still incorrect.
Also, there are still print statements
|
|
Commandline was
autopep8 -j 8 --max-line-length 120 --in-place --recursive --exclude "*gitdb*,*async*" git/
|
|
|
|
Fixed most pressing issues, more to come in next commit as we introduced
a regression here.
Conflicts:
git/objects/commit.py
git/refs/log.py
git/refs/symbolic.py
|
|
W291 trailing whitespace
|
|
E261 at least two spaces before inline comment
|
|
E201 whitespace after '('
E202 whitespace before ')'
E203 whitespace before ':'
E225 missing whitespace around operator
E226 missing whitespace around arithmetic operator
E227 missing whitespace around bitwise or shift operator
E228 missing whitespace around modulo operator
E231 missing whitespace after ','
E241 multiple spaces after ','
E251 unexpected spaces around keyword / parameter equals
|
|
E301 expected 1 blank line, found 0
E302 expected 2 blank lines, found 1
E303 too many blank lines (n)
|
|
W191 indentation contains tabs
E221 multiple spaces before operator
E222 multiple spaces after operator
E225 missing whitespace around operator
E271 multiple spaces after keyword
W292 no newline at end of file
W293 blank line contains whitespace
W391 blank line at end of file
|
|
|
|
|
|
probably a good idea to go a little more pep8 (and fix sins of my youth ;) )
|
|
command communicates
|
|
platform.system makes a system call itself
|
|
adjusted
|
