From ac4f7d34f8752ab78949efcaa9f0bd938df33622 Mon Sep 17 00:00:00 2001 From: Hugo Date: Sun, 18 Mar 2018 21:33:18 +0200 Subject: Rewrite unnecessary dict/list/tuple calls as literals --- git/remote.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'git/remote.py') diff --git a/git/remote.py b/git/remote.py index 813566a2..947616dc 100644 --- a/git/remote.py +++ b/git/remote.py @@ -663,7 +663,7 @@ class Remote(LazyMixin, Iterable): # lines which are no progress are fetch info lines # this also waits for the command to finish # Skip some progress lines that don't provide relevant information - fetch_info_lines = list() + fetch_info_lines = [] # Basically we want all fetch info lines which appear to be in regular form, and thus have a # command character. Everything else we ignore, cmds = set(FetchInfo._flag_map.keys()) -- cgit v1.2.3 From 34cce402e23a21ba9c3fdf5cd7f27a85e65245c2 Mon Sep 17 00:00:00 2001 From: Hugo Date: Sun, 18 Mar 2018 21:40:28 +0200 Subject: Remove unnecessary list comprehension - 'any' can take a generator --- git/remote.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'git/remote.py') diff --git a/git/remote.py b/git/remote.py index 947616dc..8aec68e1 100644 --- a/git/remote.py +++ b/git/remote.py @@ -542,7 +542,7 @@ class Remote(LazyMixin, Iterable): if ' Push URL:' in line: yield line.split(': ')[-1] except GitCommandError as ex: - if any([msg in str(ex) for msg in ['correct access rights', 'cannot run ssh']]): + if any(msg in str(ex) for msg in ['correct access rights', 'cannot run ssh']): # If ssh is not setup to access this repository, see issue 694 result = Git().execute( ['git', 'config', '--get', 'remote.%s.url' % self.name] -- cgit v1.2.3