From b377c07200392ac35a6ed668673451d3c9b1f5c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steve=20Fr=C3=A9cinaux?= Date: Fri, 5 Sep 2008 21:51:14 +0200 Subject: Use a dictionnary for tree contents It seems more natural to use a dictionnary for directories, since we usually want to access them by name, and entry order is not relevant. Also, finding a particular blob given its name is O(1) instead of O(N). --- test/git/test_repo.py | 4 ++-- test/git/test_tree.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/git/test_repo.py b/test/git/test_repo.py index 7550e1d6..c7a4c01b 100644 --- a/test/git/test_repo.py +++ b/test/git/test_repo.py @@ -96,8 +96,8 @@ class TestRepo(object): tree = self.repo.tree('master') - assert_equal(4, len([c for c in tree.contents if isinstance(c, Blob)])) - assert_equal(3, len([c for c in tree.contents if isinstance(c, Tree)])) + assert_equal(4, len([c for c in tree.contents.values() if isinstance(c, Blob)])) + assert_equal(3, len([c for c in tree.contents.values() if isinstance(c, Tree)])) assert_true(git.called) assert_equal(git.call_args, (('ls_tree', 'master'), {})) diff --git a/test/git/test_tree.py b/test/git/test_tree.py index 957b8962..d66764b3 100644 --- a/test/git/test_tree.py +++ b/test/git/test_tree.py @@ -18,7 +18,7 @@ class TestTree(object): tree = self.repo.tree('master') - child = tree.contents[-1] + child = tree.contents['grit'] child.contents child.contents -- cgit v1.2.3