PROJ/src/nad2bin.c, branch rfc4_dev

cpp conversion: minimal steps to fix compilation errors, not warnings

2018-12-26T09:08:53+00:00

Fix warnings found by clang with new warning flags to be added in later commit

2018-05-30T09:48:28+00:00

Fixes consist in:
- no use of comma operator for multi statement purpose
- avoid confusing comma in for loops first and third clauses
- avoid implicit long to int casts by storing to long, or explicit bound checking before cast

Avoid 'Found calculation inside sizeof()' false positive with older cppcheck versions

2018-03-14T19:25:13+00:00

Avoid 'invalidscanf,scanf without field width limits can crash with huge input data on some versions of libc' with older cppcheck versions

2018-03-14T19:25:12+00:00

Fix 'src/nad2bin.c:80,style,arrayIndexThenCheck,Array index 'i' is used before limits check' false positive cppcheck warning

2018-03-12T20:02:35+00:00

Declare non-local variables as const where possible

2017-12-17T22:34:40+00:00

Having non-const variables of static lifetime or even global scope is
usually a bad idea. These variables are inherently constants, and this
should be enforced.

This required marking some functions as not modifying input parameters
and marking some pointers as pointers to const.

One advantage is that the compiler usually puts const static variables
in a read-only code segment, so they can't be modified physically.
This can be verified with `nm` (on POSIX systems).

To avoid changes to the public API, functions returning non-const
pointers to data tables were left intact, but the returned data may not
be modified. Internally we prefer using the proj_list_* functions over
the pj_get_*_ref functions, because the former return const pointers.

Replace some asserts by compile-time assertions

2017-11-27T13:57:42+00:00

Decisions regarding the size of certain types are always made at
compile time, hence this is where the assertion should take place.

If the assertions fail, there is now a compiler error.

Raise MSVC warning level to /W4

2017-02-26T13:39:03+00:00

Fix warnings related to -Wshadow -Wnull-dereference -Wfloat-conversionr -Wmissing-prototypes -Wmissing-declarations

2017-02-26T10:25:14+00:00

Change math constants, similar to PR #372. Use M_ namespace with the de facto standard M_PI and its ilk. Change names that are widely used in the project to be in the M_ namespace, so HALFPI becomes M_HALFPI. HALFPI is #defined as M_PI_2 (the defacto standard name). #defines _USE_MATH_DEFINES for MS Visual Studio (I didn't personally test this part, but Appveyor will not build otherwise).

2016-05-28T16:26:35+00:00