aboutsummaryrefslogtreecommitdiff
path: root/nmake.opt
diff options
context:
space:
mode:
authorEven Rouault <even.rouault@spatialys.com>2018-08-10 19:36:16 +0200
committerEven Rouault <even.rouault@spatialys.com>2018-08-11 11:33:15 +0200
commit143b4d3f64e0828a3b03dd9ed997dd5412c2b25a (patch)
tree35eafecc76d4cf06aa6017db14e7124774889dae /nmake.opt
parent7b7e69690d13bd5d6b6468c6a11a81f871bd7127 (diff)
downloadPROJ-143b4d3f64e0828a3b03dd9ed997dd5412c2b25a.tar.gz
PROJ-143b4d3f64e0828a3b03dd9ed997dd5412c2b25a.zip
Fix wrong behaviour of torad_coord() with gcc 8.1 -O2 (fixes #1084)
torad_coord() of gie.c has this sequence: ``` if( cond ) axis = l->param + strlen ("axis="); n = strlen (axis); ``` When the if branch is evaluated, n is always zero even if on inspection axis is non empty The reason is that the struct ARG_list which is the type of l use a variable-length array for the param member struct ARG_list { paralist *next; char used; char param[1]; }; But this is not a proper way of declaring it, and gcc 8 has apparently optimizations to detect that l->param + 5 points out of the array, hence it optimizes strlen() to 0. Reported as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86914 According to https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html, the proper way of declaring such arrays is to use [0]
Diffstat (limited to 'nmake.opt')
0 files changed, 0 insertions, 0 deletions