From 86530f3146ec091c26652e60067088dc3e067fae Mon Sep 17 00:00:00 2001 From: Even Rouault Date: Wed, 19 Feb 2020 22:14:15 +0100 Subject: Fix wrong byte-swapping for NTv2 grids affecting master after RFC4 work (fixes #1938) And add testing of both little-endian and big-endian NTv2 files --- data/Makefile.am | 2 ++ data/tests/test_hgrid_big_endian.gsb | Bin 0 -> 624 bytes data/tests/test_hgrid_little_endian.gsb | Bin 0 -> 624 bytes src/grids.cpp | 5 ++++- test/gie/more_builtins.gie | 20 ++++++++++++++++++++ 5 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 data/tests/test_hgrid_big_endian.gsb create mode 100644 data/tests/test_hgrid_little_endian.gsb diff --git a/data/Makefile.am b/data/Makefile.am index b48e87a4..e284c6e0 100644 --- a/data/Makefile.am +++ b/data/Makefile.am @@ -87,6 +87,8 @@ EXTRA_DIST = proj.ini GL27 nad.lst nad27 nad83 \ tests/nkgrf03vel_realigned_z_extract.gtx \ tests/test_hgrid_with_two_level_of_subgrids_no_grid_name.tif \ tests/us_noaa_geoid06_ak_subset_at_antimeridian.tif \ + tests/test_hgrid_little_endian.gsb \ + tests/test_hgrid_big_endian.gsb \ generate_all_sql_in.cmake sql_filelist.cmake \ $(SQL_ORDERED_LIST) diff --git a/data/tests/test_hgrid_big_endian.gsb b/data/tests/test_hgrid_big_endian.gsb new file mode 100644 index 00000000..91f2189d Binary files /dev/null and b/data/tests/test_hgrid_big_endian.gsb differ diff --git a/data/tests/test_hgrid_little_endian.gsb b/data/tests/test_hgrid_little_endian.gsb new file mode 100644 index 00000000..13b37392 Binary files /dev/null and b/data/tests/test_hgrid_little_endian.gsb differ diff --git a/src/grids.cpp b/src/grids.cpp index ec447a33..ee5ecf52 100644 --- a/src/grids.cpp +++ b/src/grids.cpp @@ -1899,7 +1899,10 @@ std::unique_ptr NTv2GridSet::open(PJ_CONTEXT *ctx, if (must_swap) { // 6 double values: southLat, northLat, eastLon, westLon, resLat, // resLon - swap_words(header + OFFSET_SOUTH_LAT, sizeof(double), 6); + for (int i = 0; i < 6; i++) { + swap_words(header + OFFSET_SOUTH_LAT + 16 * i, sizeof(double), + 1); + } swap_words(header + OFFSET_GS_COUNT, sizeof(int), 1); } diff --git a/test/gie/more_builtins.gie b/test/gie/more_builtins.gie index 424f941d..78a504ff 100644 --- a/test/gie/more_builtins.gie +++ b/test/gie/more_builtins.gie @@ -854,4 +854,24 @@ accept 0 0 0 expect 0 90 -6356752.314140356 +------------------------------------------------------------------------------- +# Test handling of endianness of NTv2 grids +------------------------------------------------------------------------------- +------------------------------------------------------------------------------- +operation +proj=hgridshift +grids=tests/test_hgrid_little_endian.gsb +------------------------------------------------------------------------------- +tolerance 2 mm +accept 4.5 52.5 0 +expect 5.875 55.375 0 +------------------------------------------------------------------------------- + +------------------------------------------------------------------------------- +operation +proj=hgridshift +grids=tests/test_hgrid_big_endian.gsb +------------------------------------------------------------------------------- +tolerance 2 mm +accept 4.5 52.5 0 +expect 5.875 55.375 0 +------------------------------------------------------------------------------- + + -- cgit v1.2.3