From a49738902a27624d835e5a6b9983a9803c322996 Mon Sep 17 00:00:00 2001
From: Even Rouault <even.rouault@spatialys.com>
Date: Mon, 12 Mar 2018 23:32:03 +0100
Subject: Fix (mostly false positive) clang static analyzer warnings about
 potential null pointer dereference

---
 src/pj_param.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

(limited to 'src/pj_param.c')

diff --git a/src/pj_param.c b/src/pj_param.c
index 133f3ea6..b52ac940 100644
--- a/src/pj_param.c
+++ b/src/pj_param.c
@@ -131,17 +131,20 @@ PROJVALUE pj_param (projCtx ctx, paralist *pl, const char *opt) {
 
     /* Not found */
     if (0==pl) {
+        /* Return value after the switch, so that the return path is */
+        /* taken in all cases */
         switch (type) {
         case 'b': case 'i':
             value.i = 0;
-            return value;
+            break;
         case 'd': case 'r':
             value.f = 0.;
-            return value;
+            break;
         case 's':
             value.s = 0;
-            return value;
+            break;
         }
+        return value;
     }
 
     /* Found parameter - now find its value */
-- 
cgit v1.2.3