diff options
| author | Timothee Cour <timothee.cour2@gmail.com> | 2019-01-28 14:21:50 -0800 |
|---|---|---|
| committer | genotrance <dev@genotrance.com> | 2019-01-28 16:47:13 -0600 |
| commit | 70deda95b795f7fbc9002cf3bf08d4ad8b0a5aa2 (patch) | |
| tree | 94d48badffcf21c67b9a38e45f68d5c22bbab4bc | |
| parent | ecb2d545088a65eb681f9a181bc39b854d39f057 (diff) | |
| download | nimterop-70deda95b795f7fbc9002cf3bf08d4ad8b0a5aa2.tar.gz nimterop-70deda95b795f7fbc9002cf3bf08d4ad8b0a5aa2.zip | |
address comments
| -rw-r--r-- | nimterop/types.nim | 20 |
1 files changed, 1 insertions, 19 deletions
diff --git a/nimterop/types.nim b/nimterop/types.nim index c9168d0..c90f2e4 100644 --- a/nimterop/types.nim +++ b/nimterop/types.nim @@ -1,22 +1,4 @@ -#[ -note: -this should pull as few dependencies as needed by the wrapper, one option is, for the types that carry a dependency, wrap the type declaration inside something like: -``` -when defined(nimteropNeeds_va_list): - type - va_list* {.importc, header:"<stdarg.h>".} = object -``` - -note: -nimterop should replace the generated wrappers with the nim-idiomatic version, eg: -``` -proc mylib(a: ptrdiff_t) => proc mylib(a: ByteAddress) -``` - -note: -as needed, provide (platform specific) nim aliases which can be used eg to compute sizeof, eg: -type foo_t* {.importc, header: "<foo.h>".} = distinct int32 -]# +# see https://github.com/genotrance/nimterop/issues/79 when (NimMajor, NimMinor, NimPatch) < (0, 19, 9): # clean this up once upgraded; adapted from std/time_t |