aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSven <sven.riede@alliedvision.com>2018-03-28 10:30:44 +0200
committerSven <sven.riede@alliedvision.com>2018-03-28 10:30:44 +0200
commitbb46394ac997171958dbec70be9d55c4b29b141c (patch)
tree7fbe0cb6a971eb46a0a2ff2add100043b3e056a6
parenteab6b9fb30fe30af43103413d7bad1228b92449d (diff)
downloadpymba-bb46394ac997171958dbec70be9d55c4b29b141c.tar.gz
pymba-bb46394ac997171958dbec70be9d55c4b29b141c.zip
revert changes for creating pull request
- "search for VimbaC DLL in current directory first" - "string decodes / encodes"
-rw-r--r--pymba/vimbadll.py27
-rw-r--r--pymba/vimbafeature.py2
-rw-r--r--pymba/vimbaobject.py2
3 files changed, 13 insertions, 18 deletions
diff --git a/pymba/vimbadll.py b/pymba/vimbadll.py
index a06aa45..4b38f9c 100644
--- a/pymba/vimbadll.py
+++ b/pymba/vimbadll.py
@@ -12,26 +12,21 @@ from .vimbaexception import VimbaException
if sys_plat == "win32":
def find_win_dll(arch):
+ """ Finds the highest versioned windows dll for the specified architecture. """
+ bases = [
+ r'C:\Program Files\Allied Vision Technologies\AVTVimba_%i.%i\VimbaC\Bin\Win%i\VimbaC.dll',
+ r'C:\Program Files\Allied Vision\Vimba_%i.%i\VimbaC\Bin\Win%i\VimbaC.dll'
+ ]
dlls = []
- candidate = r'.\VimbaC.dll'
- if os.path.isfile(candidate):
- # use local copy
- dlls.append(candidate)
- else:
- """ Finds the highest versioned windows dll for the specified architecture. """
- bases = [
- r'C:\Program Files\Allied Vision Technologies\AVTVimba_%i.%i\VimbaC\Bin\Win%i\VimbaC.dll',
- r'C:\Program Files\Allied Vision\Vimba_%i.%i\VimbaC\Bin\Win%i\VimbaC.dll'
- ]
- for base in bases:
- for major in range(3):
- for minor in range(10):
- candidate = base % (major, minor, arch)
- if os.path.isfile(candidate):
+ for base in bases:
+ for major in range(3):
+ for minor in range(10):
+ candidate = base % (major, minor, arch)
+ if os.path.isfile(candidate):
dlls.append(candidate)
if not dlls:
if 'VIMBA_HOME' in os.environ:
- candidate = os.path.join(os.environ ['VIMBA_HOME'], r'VimbaC\Bin\Win%i\VimbaC.dll' % (arch))
+ candidate = os.environ ['VIMBA_HOME'] + '\VimbaC\Bin\Win%i\VimbaC.dll' % (arch)
if os.path.isfile(candidate):
dlls.append(candidate)
if not dlls:
diff --git a/pymba/vimbafeature.py b/pymba/vimbafeature.py
index 97473ef..88275ce 100644
--- a/pymba/vimbafeature.py
+++ b/pymba/vimbafeature.py
@@ -203,7 +203,7 @@ class VimbaFeature(object):
# create args
bufferSize = 256
- valueToGet = create_string_buffer(('\000' * bufferSize).encode())
+ valueToGet = create_string_buffer('\000' * bufferSize)
sizeFilled = c_uint32()
errorCode = VimbaDLL.featureStringGet(self._handle,
diff --git a/pymba/vimbaobject.py b/pymba/vimbaobject.py
index 69a047c..695a011 100644
--- a/pymba/vimbaobject.py
+++ b/pymba/vimbaobject.py
@@ -138,7 +138,7 @@ class VimbaObject(object):
list -- names of possible enum values (for enum features only).
"""
# can't cache this, need to look it up live
- return VimbaFeature(featureName, self._handle).range
+ return VimbaFeature(featureName.encode(), self._handle).range
def runFeatureCommand(self, featureName):
"""