From bdcb16e7bbbc216ad70686047e7fa5fee4e70fd0 Mon Sep 17 00:00:00 2001 From: Ray Date: Sun, 22 Sep 2019 21:47:19 +0200 Subject: Review PR and comments --- src/models.c | 3 ++- src/rlgl.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/models.c b/src/models.c index 3e0cce44..90f3290a 100644 --- a/src/models.c +++ b/src/models.c @@ -2921,7 +2921,8 @@ static Model LoadOBJ(const char *fileName) tinyobj_attrib_free(&attrib); tinyobj_shapes_free(meshes, meshCount); tinyobj_materials_free(materials, materialCount); - RL_FREE(data); // oh ray how did you miss this...! :-p + + RL_FREE(data); } // NOTE: At this point we have all model data loaded diff --git a/src/rlgl.h b/src/rlgl.h index 8eae4426..2de1fbbc 100644 --- a/src/rlgl.h +++ b/src/rlgl.h @@ -2967,8 +2967,8 @@ char *LoadText(const char *fileName) Shader LoadShader(const char *vsFileName, const char *fsFileName) { Shader shader = { 0 }; - // double allocation causing leak (allocation done in LoadShaderCode) - //shader.locs = (int *)RL_CALLOC(MAX_SHADER_LOCATIONS, sizeof(int)); + + // NOTE: Shader.locs is allocated by LoadShaderCode() char *vShaderStr = NULL; char *fShaderStr = NULL; -- cgit v1.2.3