Improve Strings::split()

1 files changed, 6 insertions, 7 deletions

diff --git a/toolsrc/src/vcpkg_Strings.cpp b/toolsrc/src/vcpkg_Strings.cpp
index e53cfa1ef..b974b0a06 100644
--- a/toolsrc/src/vcpkg_Strings.cpp
+++ b/toolsrc/src/vcpkg_Strings.cpp
@@ -125,17 +125,16 @@ namespace vcpkg::Strings
         std::vector<std::string> output;
 
         size_t i = 0;
-        size_t pos = s.find(delimiter);
-        while (pos != std::string::npos)
+        for (size_t pos = s.find(delimiter); pos != std::string::npos;  pos = s.find(delimiter, pos))
         {
             output.push_back(s.substr(i, pos - i));
             i = ++pos;
-            pos = s.find(delimiter, pos);
+        }
 
-            if (pos == std::string::npos && i != s.length()) // The second check is so no items are added if there is nothing after the last delimiter
-            {
-                output.push_back(s.substr(i, s.length()));
-            }
+        // Add the rest of the string after the last delimiter, unless there is nothing after it
+        if (i != s.length())
+        {
+            output.push_back(s.substr(i, s.length()));
         }
 
         return output;