diff options
| author | Alexander Karatarakis <alkarata@microsoft.com> | 2017-09-01 17:13:45 -0700 |
|---|---|---|
| committer | Alexander Karatarakis <alkarata@microsoft.com> | 2017-09-01 17:13:45 -0700 |
| commit | e25a125d8540f13410008dff7281b5d679ac9fcb (patch) | |
| tree | f310a7960d0608da636965734168b2e8791f7b95 | |
| parent | b76ac1da157c9c86cb451c871ea5ae0ddf74dbb9 (diff) | |
| download | vcpkg-e25a125d8540f13410008dff7281b5d679ac9fcb.tar.gz vcpkg-e25a125d8540f13410008dff7281b5d679ac9fcb.zip | |
Don't return by const copy
| -rw-r--r-- | toolsrc/include/SourceParagraph.h | 2 | ||||
| -rw-r--r-- | toolsrc/src/SourceParagraph.cpp | 6 |
2 files changed, 2 insertions, 6 deletions
diff --git a/toolsrc/include/SourceParagraph.h b/toolsrc/include/SourceParagraph.h index 8563d83b0..3ee2138f1 100644 --- a/toolsrc/include/SourceParagraph.h +++ b/toolsrc/include/SourceParagraph.h @@ -27,7 +27,7 @@ namespace vcpkg // zlib[uwp] becomes Dependency{"zlib", "uwp"} std::vector<Dependency> expand_qualified_dependencies(const std::vector<std::string>& depends); - const std::string to_string(const Dependency& dep); + std::string to_string(const Dependency& dep); struct FeatureParagraph { diff --git a/toolsrc/src/SourceParagraph.cpp b/toolsrc/src/SourceParagraph.cpp index 64b7bbad1..d8fa37914 100644 --- a/toolsrc/src/SourceParagraph.cpp +++ b/toolsrc/src/SourceParagraph.cpp @@ -220,11 +220,7 @@ namespace vcpkg return FeatureSpec::from_strings_and_triplet(filter_dependencies(deps, t), t); } - const std::string to_string(const Dependency& dep) - { - std::string name = dep.name(); - return name; - } + std::string to_string(const Dependency& dep) { return dep.name(); } ExpectedT<Supports, std::vector<std::string>> Supports::parse(const std::vector<std::string>& strs) { |