diff options
| author | Be <be@mixxx.org> | 2021-08-12 15:56:51 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-12 15:56:51 -0700 |
| commit | d306ab43c77c28d2f1d002093db6d4386cd7b333 (patch) | |
| tree | 43f0b5027f3910289a34844a15a39c05aa033ce8 /ports/ffmpeg | |
| parent | 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 (diff) | |
| download | vcpkg-d306ab43c77c28d2f1d002093db6d4386cd7b333.tar.gz vcpkg-d306ab43c77c28d2f1d002093db6d4386cd7b333.zip | |
[fdk-aac] make patent-encumbered HE-AAC optional (#16007)
* [fdk-aac] make patent-encumbered HE-AAC optional
By default, use a fork of fdk-aac (which was originally written
by Fraunhofer for the Android Open Source Project) which has
support for the patent-encumbered HE-AAC, HE-AACv2, and xHE-AAC
profiles removed. This fork is used by Fedora and Arch Linux to
provide support for most AAC use cases without patent licensing
fees and to permit combining it with GPL software. The upstream
fdk-aac with support for all AAC profiles can be built with the
new 'he-aac' option for this port.
Fedora Legal's opinion, from
https://bugzilla.redhat.com/show_bug.cgi?id=1501522#c112 :
The Fedora Project is aware that the Free Software Foundation
has stated that the Fraunhofer FDK AAC license is GPL
incompatible, specifically, because of Clause 3.
We believe that the fdk-aac software codec implementation that we
wish to include in Fedora is no longer encumbered by AAC patents.
This fact means that Clause 3 in the FDK AAC license is a "no op",
or to put it plainly, if no patents are in play, there are no
patent licenses to disclaim. For this (and only this) specific
implementation of fdk-aac, we believe that the FDK AAC license is
GPL compatible.
Also:
* remove restriction on dynamic linking. Upstream has a .def
file which is used by CMake.
* replace deprecated vcpkg functions
* [ffmpeg] use fdk-aac[he-aac] for fdk-aac feature
There is no point to this feature without HE-AAC because FFmpeg has
its own AAC codec that does not support HE-AAC.
Diffstat (limited to 'ports/ffmpeg')
| -rw-r--r-- | ports/ffmpeg/vcpkg.json | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/ports/ffmpeg/vcpkg.json b/ports/ffmpeg/vcpkg.json index 854bcaf1a..db07eba9b 100644 --- a/ports/ffmpeg/vcpkg.json +++ b/ports/ffmpeg/vcpkg.json @@ -1,7 +1,7 @@ { "name": "ffmpeg", "version": "4.4", - "port-version": 12, + "port-version": 13, "description": [ "a library to decode, encode, transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have created.", "FFmpeg is the leading multimedia framework, able to decode, encode, transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have created. It supports the most obscure ancient formats up to the cutting edge. No matter if they were designed by some standards committee, the community or a corporation. It is also highly portable: FFmpeg compiles, runs, and passes our testing infrastructure FATE across Linux, Mac OS X, Microsoft Windows, the BSDs, Solaris, etc. under a wide variety of build environments, machine architectures, and configurations." @@ -299,9 +299,15 @@ ] }, "fdk-aac": { - "description": "AAC de/encoding via libfdk-aac", + "description": "AAC de/encoding via libfdk-aac, **including GPL-incompatible patent-encumbered HE-AAC**. If you do not require HE-AAC, use the built-in FFmpeg AAC codec.", "dependencies": [ - "fdk-aac", + { + "name": "fdk-aac", + "default-features": false, + "features": [ + "he-aac" + ] + }, { "name": "ffmpeg", "default-features": false, |