[OpenCV] fix compatibility with VTK9 (#12785)

3 files changed, 549 insertions, 34 deletions

diff --git a/ports/opencv3/0005-fix-vtk9.patch b/ports/opencv3/0005-fix-vtk9.patch
new file mode 100644
index 000000000..137302ee3
--- /dev/null
+++ b/ports/opencv3/0005-fix-vtk9.patch
@@ -0,0 +1,484 @@
+diff --git a/cmake/OpenCVDetectVTK.cmake b/cmake/OpenCVDetectVTK.cmake
+index 1495688..4c83504 100644
+--- a/cmake/OpenCVDetectVTK.cmake
++++ b/cmake/OpenCVDetectVTK.cmake
+@@ -1,12 +1,30 @@
++# VTK 9.0
++if(NOT VTK_FOUND)
++  find_package(VTK 9 QUIET NAMES vtk COMPONENTS
++    FiltersExtraction
++    FiltersSources
++    FiltersTexture
++    IOExport
++    IOGeometry
++    IOPLY
++    InteractionStyle
++    RenderingCore
++    RenderingLOD
++    RenderingOpenGL2
++    NO_MODULE)
++endif()
++
+ # VTK 6.x components
+-find_package(VTK QUIET COMPONENTS vtkInteractionStyle vtkRenderingLOD vtkIOPLY vtkFiltersTexture vtkRenderingFreeType vtkIOExport NO_MODULE)
+-IF(VTK_FOUND)
+-  IF(VTK_RENDERING_BACKEND) #in vtk 7, the rendering backend is exported as a var.
++if(NOT VTK_FOUND)
++  find_package(VTK QUIET COMPONENTS vtkInteractionStyle vtkRenderingLOD vtkIOPLY vtkFiltersTexture vtkRenderingFreeType vtkIOExport NO_MODULE)
++  IF(VTK_FOUND)
++    IF(VTK_RENDERING_BACKEND) #in vtk 7, the rendering backend is exported as a var.
+       find_package(VTK QUIET COMPONENTS vtkRendering${VTK_RENDERING_BACKEND} vtkInteractionStyle vtkRenderingLOD vtkIOPLY vtkFiltersTexture vtkRenderingFreeType vtkIOExport vtkIOGeometry NO_MODULE)
+-  ELSE(VTK_RENDERING_BACKEND)
++    ELSE(VTK_RENDERING_BACKEND)
+       find_package(VTK QUIET COMPONENTS vtkRenderingOpenGL vtkInteractionStyle vtkRenderingLOD vtkIOPLY vtkFiltersTexture vtkRenderingFreeType vtkIOExport NO_MODULE)
+-  ENDIF(VTK_RENDERING_BACKEND)
+-ENDIF(VTK_FOUND)
++    ENDIF(VTK_RENDERING_BACKEND)
++  ENDIF(VTK_FOUND)
++endif()
+ 
+ # VTK 5.x components
+ if(NOT VTK_FOUND)
+diff --git a/modules/viz/CMakeLists.txt b/modules/viz/CMakeLists.txt
+index 256b464..92698c3 100644
+--- a/modules/viz/CMakeLists.txt
++++ b/modules/viz/CMakeLists.txt
+@@ -3,7 +3,6 @@ if(NOT HAVE_VTK)
+ endif()
+ 
+ set(the_description "Viz")
+-include(${VTK_USE_FILE})
+ 
+ if(NOT BUILD_SHARED_LIBS)
+   # We observed conflict between builtin 3rdparty libraries and
+@@ -27,7 +26,14 @@ endif()
+ ocv_warnings_disable(CMAKE_CXX_FLAGS -Winconsistent-missing-override -Wsuggest-override)
+ 
+ ocv_define_module(viz opencv_core WRAP python)
+-ocv_target_link_libraries(${the_module} PRIVATE ${VTK_LIBRARIES})
++
++if (VTK_VERSION VERSION_LESS "8.90.0")
++  include(${VTK_USE_FILE})
++  ocv_target_link_libraries(${the_module} PRIVATE ${VTK_LIBRARIES})
++else ()
++  ocv_target_link_libraries(${the_module} PRIVATE ${VTK_LIBRARIES})
++  vtk_module_autoinit(TARGETS ${the_module} MODULES ${VTK_LIBRARIES})
++endif()
+ 
+ if(APPLE AND BUILD_opencv_viz)
+   ocv_target_link_libraries(${the_module} PRIVATE "-framework Cocoa")
+diff --git a/modules/viz/src/precomp.hpp b/modules/viz/src/precomp.hpp
+index f92fdb6..4c4bf7c 100644
+--- a/modules/viz/src/precomp.hpp
++++ b/modules/viz/src/precomp.hpp
+@@ -133,7 +133,8 @@
+ #include <vtkColorTransferFunction.h>
+ #include <vtkStreamingDemandDrivenPipeline.h>
+ #include <vtkLight.h>
+-#include "vtkCallbackCommand.h"
++#include <vtkCallbackCommand.h>
++#include <vtkVersion.h>
+ 
+ #if !defined(_WIN32) || defined(__CYGWIN__)
+ # include <unistd.h> /* unlink */
+@@ -149,6 +150,11 @@
+ #include "vtk/vtkTrajectorySource.h"
+ #include "vtk/vtkImageMatSource.h"
+ 
++#if VTK_MAJOR_VERSION >= 9
++typedef vtkIdType const * CellIterT;
++#else
++typedef vtkIdType * CellIterT;
++#endif
+ 
+ #include <opencv2/core.hpp>
+ #include <opencv2/viz.hpp>
+diff --git a/modules/viz/src/types.cpp b/modules/viz/src/types.cpp
+index 65571a1..e9a470c 100644
+--- a/modules/viz/src/types.cpp
++++ b/modules/viz/src/types.cpp
+@@ -97,10 +97,12 @@ cv::viz::Mesh cv::viz::Mesh::load(const String& file, int type)
+     // Now handle the polygons
+     vtkSmartPointer<vtkCellArray> polygons = polydata->GetPolys();
+     mesh.polygons.create(1, polygons->GetSize(), CV_32SC1);
++    mesh.polygons = 0;
+     int* poly_ptr = mesh.polygons.ptr<int>();
+ 
+     polygons->InitTraversal();
+-    vtkIdType nr_cell_points, *cell_points;
++    vtkIdType nr_cell_points;
++    CellIterT cell_points;
+     while (polygons->GetNextCell(nr_cell_points, cell_points))
+     {
+         *poly_ptr++ = nr_cell_points;
+diff --git a/modules/viz/src/vizimpl.cpp b/modules/viz/src/vizimpl.cpp
+index 23cba75..89f1249 100644
+--- a/modules/viz/src/vizimpl.cpp
++++ b/modules/viz/src/vizimpl.cpp
+@@ -55,8 +55,17 @@ cv::viz::Viz3d::VizImpl::VizImpl(const String &name) : spin_once_state_(false),
+ 
+     // Create render window
+     window_ = vtkSmartPointer<vtkRenderWindow>::New();
+-    cv::Vec2i window_size = cv::Vec2i(window_->GetScreenSize()) / 2;
+-    window_->SetSize(window_size.val);
++    int * sz = window_->GetScreenSize();
++    if (sz)
++    {
++        cv::Vec2i window_size = cv::Vec2i(sz) / 2;
++        window_->SetSize(window_size.val);
++    }
++    else
++    {
++        int new_sz[2] = { 640, 480 };
++        window_->SetSize(new_sz);
++    }
+     window_->AddRenderer(renderer_);
+ 
+     // Create the interactor style
+diff --git a/modules/viz/src/vtk/vtkOBJWriter.cpp b/modules/viz/src/vtk/vtkOBJWriter.cpp
+index 296b6eb..2e5764f 100644
+--- a/modules/viz/src/vtk/vtkOBJWriter.cpp
++++ b/modules/viz/src/vtk/vtkOBJWriter.cpp
+@@ -72,7 +72,7 @@ void cv::viz::vtkOBJWriter::WriteData()
+     }
+ 
+     vtkDebugMacro(<<"Opening vtk file for writing...");
+-    ostream *outfilep = new ofstream(this->FileName, ios::out);
++    std::ostream *outfilep = new std::ofstream(this->FileName, ios::out);
+     if (outfilep->fail())
+     {
+         vtkErrorMacro(<< "Unable to open file: "<< this->FileName);
+@@ -127,7 +127,8 @@ void cv::viz::vtkOBJWriter::WriteData()
+     // write out verts if any
+     if (input->GetNumberOfVerts() > 0)
+     {
+-        vtkIdType npts = 0, *index = 0;
++        vtkIdType npts = 0;
++        CellIterT index = 0;
+         vtkCellArray *cells = input->GetVerts();
+         for (cells->InitTraversal(); cells->GetNextCell(npts, index); )
+         {
+@@ -141,7 +142,8 @@ void cv::viz::vtkOBJWriter::WriteData()
+     // write out lines if any
+     if (input->GetNumberOfLines() > 0)
+     {
+-        vtkIdType npts = 0, *index = 0;
++        vtkIdType npts = 0;
++        CellIterT index = 0;
+         vtkCellArray *cells = input->GetLines();
+         for (cells->InitTraversal(); cells->GetNextCell(npts, index); )
+         {
+@@ -162,7 +164,8 @@ void cv::viz::vtkOBJWriter::WriteData()
+     // write out polys if any
+     if (input->GetNumberOfPolys() > 0)
+     {
+-        vtkIdType npts = 0, *index = 0;
++        vtkIdType npts = 0;
++        CellIterT index = 0;
+         vtkCellArray *cells = input->GetPolys();
+         for (cells->InitTraversal(); cells->GetNextCell(npts, index); )
+         {
+@@ -191,7 +194,8 @@ void cv::viz::vtkOBJWriter::WriteData()
+     // write out tstrips if any
+     if (input->GetNumberOfStrips() > 0)
+     {
+-        vtkIdType npts = 0, *index = 0;
++        vtkIdType npts = 0;
++        CellIterT index = 0;
+         vtkCellArray *cells = input->GetStrips();
+         for (cells->InitTraversal(); cells->GetNextCell(npts, index); )
+         {
+diff --git a/modules/viz/src/vtk/vtkXYZReader.cpp b/modules/viz/src/vtk/vtkXYZReader.cpp
+index 57726ea..3b9265f 100644
+--- a/modules/viz/src/vtk/vtkXYZReader.cpp
++++ b/modules/viz/src/vtk/vtkXYZReader.cpp
+@@ -77,7 +77,7 @@ int cv::viz::vtkXYZReader::RequestData(vtkInformation*, vtkInformationVector**,
+     }
+ 
+     // Open the input file.
+-    ifstream fin(this->FileName);
++    std::ifstream fin(this->FileName);
+     if(!fin)
+     {
+         vtkErrorMacro("Error opening file " << this->FileName);
+diff --git a/modules/viz/src/vtk/vtkXYZWriter.cpp b/modules/viz/src/vtk/vtkXYZWriter.cpp
+index cf95e3c..56a26b3 100644
+--- a/modules/viz/src/vtk/vtkXYZWriter.cpp
++++ b/modules/viz/src/vtk/vtkXYZWriter.cpp
+@@ -69,7 +69,7 @@ void cv::viz::vtkXYZWriter::WriteData()
+     }
+ 
+     vtkDebugMacro(<<"Opening vtk file for writing...");
+-    ostream *outfilep = new ofstream(this->FileName, ios::out);
++    std::ostream *outfilep = new std::ofstream(this->FileName, ios::out);
+     if (outfilep->fail())
+     {
+         vtkErrorMacro(<< "Unable to open file: "<< this->FileName);
+diff --git a/modules/viz/test/test_tutorial2.cpp b/modules/viz/test/test_tutorial2.cpp
+index 6b2972f..a4b5b99 100644
+--- a/modules/viz/test/test_tutorial2.cpp
++++ b/modules/viz/test/test_tutorial2.cpp
+@@ -28,7 +28,7 @@ static void tutorial2()
+     /// Rodrigues vector
+     Vec3d rot_vec = Vec3d::all(0);
+     double translation_phase = 0.0, translation = 0.0;
+-    while(!myWindow.wasStopped())
++    for(unsigned num = 0; num < 50; ++num)
+     {
+         /* Rotation using rodrigues */
+         /// Rotate around (1,1,1)
+@@ -45,7 +45,7 @@ static void tutorial2()
+ 
+         myWindow.setWidgetPose("Cube Widget", pose);
+ 
+-        myWindow.spinOnce(1, true);
++        myWindow.spinOnce(100, true);
+     }
+ }
+ 
+diff --git a/modules/viz/test/test_tutorial3.cpp b/modules/viz/test/test_tutorial3.cpp
+index 232130f..32e33b1 100644
+--- a/modules/viz/test/test_tutorial3.cpp
++++ b/modules/viz/test/test_tutorial3.cpp
+@@ -48,7 +48,7 @@ static void tutorial3(bool camera_pov)
+         myWindow.setViewerPose(camera_pose);
+ 
+     /// Start event loop.
+-    myWindow.spin();
++    myWindow.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, tutorial3_global_view)
+diff --git a/modules/viz/test/test_viz3d.cpp b/modules/viz/test/test_viz3d.cpp
+index cdf8a00..4ab05c3 100644
+--- a/modules/viz/test/test_viz3d.cpp
++++ b/modules/viz/test/test_viz3d.cpp
+@@ -59,7 +59,7 @@ TEST(Viz_viz3d, DISABLED_develop)
+     //cv::Mat cloud = cv::viz::readCloud(get_dragon_ply_file_path());
+     //---->>>>> </to_test_in_future>
+ 
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ }} // namespace
+diff --git a/modules/viz/test/tests_simple.cpp b/modules/viz/test/tests_simple.cpp
+index 12d696d..5584483 100644
+--- a/modules/viz/test/tests_simple.cpp
++++ b/modules/viz/test/tests_simple.cpp
+@@ -56,7 +56,7 @@ TEST(Viz, show_cloud_bluberry)
+     viz.showWidget("dragon", WCloud(dragon_cloud, Color::bluberry()), pose);
+ 
+     viz.showWidget("text2d", WText("Bluberry cloud", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_cloud_random_color)
+@@ -73,7 +73,7 @@ TEST(Viz, show_cloud_random_color)
+     viz.showWidget("coosys", WCoordinateSystem());
+     viz.showWidget("dragon", WCloud(dragon_cloud, colors), pose);
+     viz.showWidget("text2d", WText("Random color cloud", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_cloud_masked)
+@@ -91,7 +91,7 @@ TEST(Viz, show_cloud_masked)
+     viz.showWidget("coosys", WCoordinateSystem());
+     viz.showWidget("dragon", WCloud(dragon_cloud), pose);
+     viz.showWidget("text2d", WText("Nan masked cloud", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_cloud_collection)
+@@ -109,7 +109,7 @@ TEST(Viz, show_cloud_collection)
+     viz.showWidget("coosys", WCoordinateSystem());
+     viz.showWidget("ccol", ccol);
+     viz.showWidget("text2d", WText("Cloud collection", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_painted_clouds)
+@@ -124,7 +124,7 @@ TEST(Viz, show_painted_clouds)
+     viz.showWidget("cloud3", WPaintedCloud(cloud, Vec3d(0.0, 0.0, -1.0), Vec3d(0.0, 0.0, 1.0), Color::blue(), Color::red()));
+     viz.showWidget("arrow", WArrow(Vec3d(0.0, 1.0, -1.0), Vec3d(0.0, 1.0, 1.0), 0.009, Color::raspberry()));
+     viz.showWidget("text2d", WText("Painted clouds", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_mesh)
+@@ -137,7 +137,7 @@ TEST(Viz, show_mesh)
+     viz.showWidget("coosys", WCoordinateSystem());
+     viz.showWidget("mesh", WMesh(mesh), pose);
+     viz.showWidget("text2d", WText("Just mesh", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_mesh_random_colors)
+@@ -152,7 +152,7 @@ TEST(Viz, show_mesh_random_colors)
+     viz.showWidget("mesh", WMesh(mesh), pose);
+     viz.setRenderingProperty("mesh", SHADING, SHADING_PHONG);
+     viz.showWidget("text2d", WText("Random color mesh", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_widget_merger)
+@@ -173,7 +173,7 @@ TEST(Viz, show_widget_merger)
+     viz.showWidget("coo", WCoordinateSystem());
+     viz.showWidget("merger", merger);
+     viz.showWidget("text2d", WText("Widget merger", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_textured_mesh)
+@@ -210,7 +210,7 @@ TEST(Viz, show_textured_mesh)
+     viz.showWidget("mesh", WMesh(mesh));
+     viz.setRenderingProperty("mesh", SHADING, SHADING_PHONG);
+     viz.showWidget("text2d", WText("Textured mesh", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_polyline)
+@@ -229,7 +229,7 @@ TEST(Viz, show_polyline)
+     viz.showWidget("polyline", WPolyLine(polyline, colors));
+     viz.showWidget("coosys", WCoordinateSystem());
+     viz.showWidget("text2d", WText("Polyline", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_sampled_normals)
+@@ -244,7 +244,7 @@ TEST(Viz, show_sampled_normals)
+     viz.showWidget("normals", WCloudNormals(mesh.cloud, mesh.normals, 30, 0.1f, Color::green()), pose);
+     viz.setRenderingProperty("normals", LINE_WIDTH, 2.0);
+     viz.showWidget("text2d", WText("Cloud or mesh normals", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_cloud_shaded_by_normals)
+@@ -260,7 +260,7 @@ TEST(Viz, show_cloud_shaded_by_normals)
+     Viz3d viz("show_cloud_shaded_by_normals");
+     viz.showWidget("cloud", cloud, pose);
+     viz.showWidget("text2d", WText("Cloud shaded by normals", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_trajectories)
+@@ -287,15 +287,15 @@ TEST(Viz, show_trajectories)
+     viz.showWidget("text2d", WText("Different kinds of supported trajectories", Point(20, 20), 20, Color::green()));
+ 
+     int i = 0;
+-    while(!viz.wasStopped())
++    for(unsigned num = 0; num < 50; ++num)
+     {
+         double a = --i % 360;
+         Vec3d pose(sin(a * CV_PI/180), 0.7, cos(a * CV_PI/180));
+         viz.setViewerPose(makeCameraPose(pose * 7.5, Vec3d(0.0, 0.5, 0.0), Vec3d(0.0, 0.1, 0.0)));
+-        viz.spinOnce(20, true);
++        viz.spinOnce(100, true);
+     }
+     viz.resetCamera();
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_trajectory_reposition)
+@@ -306,7 +306,7 @@ TEST(Viz, show_trajectory_reposition)
+     viz.showWidget("coos", WCoordinateSystem());
+     viz.showWidget("sub3", WTrajectory(Mat(path).rowRange(0, (int)path.size()/3), WTrajectory::BOTH, 0.2, Color::brown()), path.front().inv());
+     viz.showWidget("text2d", WText("Trajectory resposition to origin", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_camera_positions)
+@@ -330,7 +330,7 @@ TEST(Viz, show_camera_positions)
+     viz.showWidget("pos3", WCameraPosition(0.75), poses[1]);
+     viz.showWidget("pos4", WCameraPosition(K, gray, 3, Color::indigo()), poses[1]);
+     viz.showWidget("text2d", WText("Camera positions with images", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_overlay_image)
+@@ -353,16 +353,16 @@ TEST(Viz, show_overlay_image)
+     viz.showWidget("text2d", WText("Overlay images", Point(20, 20), 20, Color::green()));
+ 
+     int i = 0;
+-    while(!viz.wasStopped())
++    for(unsigned num = 0; num < 50; ++num)
+     {
+         double a = ++i % 360;
+         Vec3d pose(sin(a * CV_PI/180), 0.7, cos(a * CV_PI/180));
+         viz.setViewerPose(makeCameraPose(pose * 3, Vec3d(0.0, 0.5, 0.0), Vec3d(0.0, 0.1, 0.0)));
+         viz.getWidget("img1").cast<WImageOverlay>().setImage(lena * pow(sin(i*10*CV_PI/180) * 0.5 + 0.5, 1.0));
+-        viz.spinOnce(1, true);
++        viz.spinOnce(100, true);
+     }
+     viz.showWidget("text2d", WText("Overlay images (stopped)", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ 
+@@ -376,7 +376,7 @@ TEST(Viz, show_image_method)
+     viz.showImage(lena, lena.size());
+     viz.spinOnce(1500, true);
+ 
+-    cv::viz::imshow("show_image_method", make_gray(lena)).spin();
++    cv::viz::imshow("show_image_method", make_gray(lena)).spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_image_3d)
+@@ -398,13 +398,13 @@ TEST(Viz, show_image_3d)
+     viz.showWidget("text2d", WText("Images in 3D", Point(20, 20), 20, Color::green()));
+ 
+     int i = 0;
+-    while(!viz.wasStopped())
++    for(unsigned num = 0; num < 50; ++num)
+     {
+         viz.getWidget("img0").cast<WImage3D>().setImage(lena * pow(sin(i++*7.5*CV_PI/180) * 0.5 + 0.5, 1.0));
+-        viz.spinOnce(1, true);
++        viz.spinOnce(100, true);
+     }
+     viz.showWidget("text2d", WText("Images in 3D (stopped)", Point(20, 20), 20, Color::green()));
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_simple_widgets)
+@@ -431,10 +431,10 @@ TEST(Viz, show_simple_widgets)
+ 
+     viz.showWidget("grid1", WGrid(Vec2i(7,7), Vec2d::all(0.75), Color::gray()), Affine3d().translate(Vec3d(0.0, 0.0, -1.0)));
+ 
+-    viz.spin();
++    viz.spinOnce(500, true);
+     viz.getWidget("text2d").cast<WText>().setText("Different simple widgets (updated)");
+     viz.getWidget("text3d").cast<WText3D>().setText("Updated text 3D");
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ TEST(Viz, show_follower)
+@@ -446,9 +446,9 @@ TEST(Viz, show_follower)
+     viz.showWidget("t3d_2", WText3D("Simple 3D follower", Point3d(-0.5, -0.5, 0.5), 0.125, true,  Color::green()));
+     viz.showWidget("text2d", WText("Follower: text always facing camera", Point(20, 20), 20, Color::green()));
+     viz.setBackgroundMeshLab();
+-    viz.spin();
++    viz.spinOnce(500, true);
+     viz.getWidget("t3d_2").cast<WText3D>().setText("Updated follower 3D");
+-    viz.spin();
++    viz.spinOnce(500, true);
+ }
+ 
+ }} // namespace
diff --git a/ports/opencv3/CONTROL b/ports/opencv3/CONTROL
index f6c2f926b..e48c5dc1d 100644
--- a/ports/opencv3/CONTROL
+++ b/ports/opencv3/CONTROL
@@ -1,6 +1,6 @@
 Source: opencv3
 Version: 3.4.10
-Port-Version: 2
+Port-Version: 4
 Build-Depends: zlib
 Homepage: https://github.com/opencv/opencv
 Description: computer vision library
diff --git a/ports/opencv3/portfile.cmake b/ports/opencv3/portfile.cmake
index 98f3b32ed..e194e0e9a 100644
--- a/ports/opencv3/portfile.cmake
+++ b/ports/opencv3/portfile.cmake
@@ -18,6 +18,7 @@ vcpkg_from_github(
       0001-disable-downloading.patch
       0002-install-options.patch
       0003-force-package-requirements.patch
+      0005-fix-vtk9.patch
       0009-fix-uwp.patch
 )
 
@@ -44,11 +45,12 @@ vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
  "qt"       WITH_QT
  "sfm"      BUILD_opencv_sfm
  "tiff"     WITH_TIFF
+ "vtk"      WITH_VTK
  "webp"     WITH_WEBP
  "world"    BUILD_opencv_world
 )
 
-# Cannot use vcpkg_check_features() for "dnn", "ipp", ovis", "tbb", and "vtk".
+# Cannot use vcpkg_check_features() for "dnn", "ipp", ovis", "tbb"
 # As the respective value of their variables can be unset conditionally.
 set(BUILD_opencv_dnn OFF)
 if("dnn" IN_LIST FEATURES)
@@ -74,11 +76,6 @@ if("tbb" IN_LIST FEATURES)
   set(WITH_TBB ON)
 endif()
 
-set(WITH_VTK OFF)
-if("vtk" IN_LIST FEATURES)
-  set(WITH_VTK ON)
-endif()
-
 if("dnn" IN_LIST FEATURES)
   vcpkg_download_distfile(TINYDNN_ARCHIVE
     URLS "https://github.com/tiny-dnn/tiny-dnn/archive/v1.0.0a3.tar.gz"
@@ -214,11 +211,6 @@ if (VCPKG_LIBRARY_LINKAGE STREQUAL static)
     set(WITH_TBB OFF)
   endif()
 
-  if (WITH_VTK)
-    message(WARNING "VTK is currently unsupported in this build configuration, turning it off")
-    set(WITH_VTK OFF)
-  endif()
-
   if (VCPKG_TARGET_IS_WINDOWS AND BUILD_opencv_ovis)
     message(WARNING "OVIS is currently unsupported in this build configuration, turning it off")
     set(BUILD_opencv_ovis OFF)
@@ -258,6 +250,7 @@ vcpkg_configure_cmake(
         -DOPENCV_CONFIG_INSTALL_PATH=share/opencv
         -DINSTALL_TO_MANGLED_PATHS=OFF
         -DOPENCV_FFMPEG_USE_FIND_PACKAGE=FFMPEG
+        -DOPENCV_FFMPEG_SKIP_BUILD_CHECK=TRUE
         -DCMAKE_DEBUG_POSTFIX=d
         -DOPENCV_DLLVERSION=
         -DOPENCV_DEBUG_POSTFIX=d
@@ -320,7 +313,6 @@ vcpkg_configure_cmake(
         -DWITH_PROTOBUF=${BUILD_opencv_flann}
         -DWITH_OPENCLAMDBLAS=OFF
         -DWITH_TBB=${WITH_TBB}
-        -DWITH_VTK=${WITH_VTK}
         -DWITH_OPENJPEG=OFF
         ###### WITH PROPERTIES explicitly disabled, they have problems with libraries if already installed by user and that are "involuntarily" found during install
         -DWITH_LAPACK=OFF
@@ -339,17 +331,16 @@ vcpkg_copy_pdbs()
 
 if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
   file(READ ${CURRENT_PACKAGES_DIR}/share/opencv/OpenCVModules.cmake OPENCV_MODULES)
-  string(REPLACE "set(CMAKE_IMPORT_FILE_VERSION 1)"
-                 "set(CMAKE_IMPORT_FILE_VERSION 1)
-find_package(Protobuf REQUIRED)
-if(Protobuf_FOUND)
+  set(DEPS_STRING "include(CMakeFindDependencyMacro)
+find_dependency(protobuf CONFIG)
+if(protobuf_FOUND)
   if(TARGET protobuf::libprotobuf)
-    add_library(libprotobuf INTERFACE IMPORTED)
+    add_library (libprotobuf INTERFACE IMPORTED)
     set_target_properties(libprotobuf PROPERTIES
       INTERFACE_LINK_LIBRARIES protobuf::libprotobuf
     )
   else()
-    add_library(libprotobuf UNKNOWN IMPORTED)
+    add_library (libprotobuf UNKNOWN IMPORTED)
     set_target_properties(libprotobuf PROPERTIES
       IMPORTED_LOCATION \"${Protobuf_LIBRARY}\"
       INTERFACE_INCLUDE_DIRECTORIES \"${Protobuf_INCLUDE_DIR}\"
@@ -357,25 +348,64 @@ if(Protobuf_FOUND)
     )
   endif()
 endif()
-find_package(CUDA QUIET)
-find_package(Threads QUIET)
-find_package(TIFF QUIET)
-find_package(HDF5 QUIET)
-find_package(Freetype QUIET)
-find_package(Ogre QUIET)
-find_package(gflags QUIET)
-find_package(Ceres QUIET)
-find_package(ade QUIET)
-find_package(VTK QUIET)
-find_package(OpenMP QUIET)
-find_package(Tesseract QUIET)
-find_package(OpenEXR QUIET)
+find_dependency(Threads)")
+  if("tiff" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(TIFF)")
+  endif()
+  if("cuda" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(CUDA)")
+  endif()
+  if(BUILD_opencv_quality)
+    string(APPEND DEPS_STRING "
+# C language is required for try_compile tests in FindHDF5
+enable_language(C)
+find_dependency(HDF5)
+find_dependency(Tesseract)")
+  endif()
+  if(WITH_TBB)
+    string(APPEND DEPS_STRING "\nfind_dependency(TBB)")
+  endif()
+  if("vtk" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(VTK)")
+  endif()
+  if("sfm" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(gflags CONFIG)\nfind_dependency(Ceres CONFIG)")
+  endif()
+  if("eigen" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(Eigen3 CONFIG)")
+  endif()
+  if("openexr" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(OpenEXR CONFIG)")
+  endif()
+  if(WITH_OPENMP)
+    string(APPEND DEPS_STRING "\nfind_dependency(OpenMP CONFIG)")
+  endif()
+  if(BUILD_opencv_ovis)
+    string(APPEND DEPS_STRING "\nfind_dependency(Ogre)\nfind_dependency(Freetype)")
+  endif()
+  if("qt" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "
 set(CMAKE_AUTOMOC ON)
 set(CMAKE_AUTORCC ON)
 set(CMAKE_AUTOUIC ON)
+find_dependency(Qt5 COMPONENTS OpenGL Concurrent Test)")
+  endif()
+  if("ade" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(ade)")
+  endif()
+  if("gdcm" IN_LIST FEATURES)
+    string(APPEND DEPS_STRING "\nfind_dependency(GDCM)")
+  endif()
 
-find_package(Qt5 COMPONENTS OpenGL Concurrent Test QUIET)
-find_package(GDCM QUIET)" OPENCV_MODULES "${OPENCV_MODULES}")
+  string(REPLACE "set(CMAKE_IMPORT_FILE_VERSION 1)"
+                 "set(CMAKE_IMPORT_FILE_VERSION 1)\n${DEPS_STRING}" OPENCV_MODULES "${OPENCV_MODULES}")
+
+  if(WITH_OPENMP)
+    string(REPLACE "set_target_properties(opencv_core PROPERTIES
+  INTERFACE_LINK_LIBRARIES \""
+                   "set_target_properties(opencv_core PROPERTIES
+  INTERFACE_LINK_LIBRARIES \"\$<LINK_ONLY:OpenMP::OpenMP_CXX>;" OPENCV_MODULES "${OPENCV_MODULES}")
+  endif()
 
   if(BUILD_opencv_ovis)
     string(REPLACE "OgreGLSupportStatic"
@@ -384,6 +414,7 @@ find_package(GDCM QUIET)" OPENCV_MODULES "${OPENCV_MODULES}")
 
   file(WRITE ${CURRENT_PACKAGES_DIR}/share/opencv/OpenCVModules.cmake "${OPENCV_MODULES}")
 
+
   file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin)
 endif()