diff options
| author | Daniel Strommen <nerdile@outlook.com> | 2017-10-05 19:47:41 -0700 |
|---|---|---|
| committer | Daniel Strommen <nerdile@outlook.com> | 2017-10-05 19:47:41 -0700 |
| commit | 0643bd6581182a537b23c885b1c6b27e33e61dc4 (patch) | |
| tree | f2992432e1b04c98aa27c7a429778daeb6326dbf /scripts | |
| parent | 9ae4b9f885c6bb3ede212d42c51f2b96fbfc86dd (diff) | |
| download | vcpkg-0643bd6581182a537b23c885b1c6b27e33e61dc4.tar.gz vcpkg-0643bd6581182a537b23c885b1c6b27e33e61dc4.zip | |
Fix Win10SDK detection during Bootstrap
When multiple Win10 SDK's are installed, like Insider previews,
depending on the SDK installation, it may not contain the um headers.
There is already a loop for trying to find the newest Win10 SDK
that has full headers, but it's returning at the first failure,
rather than continuing the loop to the next iteration.
Also, use Join-Path instead of manual path appending, to normalize
the extra \ at the end of the sdk root value. In some cases paths
with double backslashes can be interpreted as a fallback syntax for
UNC paths. Join-Path normalizes the path appropriately.
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/getWindowsSDK.ps1 | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/scripts/getWindowsSDK.ps1 b/scripts/getWindowsSDK.ps1 index 9aebae8e3..f4537ddc3 100644 --- a/scripts/getWindowsSDK.ps1 +++ b/scripts/getWindowsSDK.ps1 @@ -20,7 +20,7 @@ $validInstances = New-Object System.Collections.ArrayList # Windows 10 SDK function CheckWindows10SDK($path) { - $folder = "$path\Include" + $folder = (Join-Path $path "Include") if (!(Test-Path $folder)) { Write-Verbose "$folder - Not Found" @@ -37,7 +37,7 @@ function CheckWindows10SDK($path) if (!(Test-Path $windowsheader)) { Write-Verbose "$windowsheader - Not Found" - return + continue } Write-Verbose "$windowsheader - Found" @@ -45,7 +45,7 @@ function CheckWindows10SDK($path) if (!(Test-Path $ddkheader)) { Write-Verbose "$ddkheader - Not Found" - return + continue } Write-Verbose "$ddkheader - Found" @@ -106,4 +106,4 @@ foreach ($instance in $validInstances) } } -throw "Could not detect a Windows SDK / TargetPlatformVersion"
\ No newline at end of file +throw "Could not detect a Windows SDK / TargetPlatformVersion" |
