[vcpkg] Fix regression in error messages with registries/versioning (#15709)

* [vcpkg] Fix regression in error messages with registries/versioning

* [vcpkg] Clean up redundant re-parsing with try_load_overlay_port

* [vcpkg] Deduplicate PathsPortfileProvider

* [vcpkg] Restore uses of Checks::exit_maybe_upgrade after merge

1 files changed, 10 insertions, 0 deletions

diff --git a/toolsrc/src/vcpkg-test/dependencies.cpp b/toolsrc/src/vcpkg-test/dependencies.cpp
index 8f936abc3..c6241ebe0 100644
--- a/toolsrc/src/vcpkg-test/dependencies.cpp
+++ b/toolsrc/src/vcpkg-test/dependencies.cpp
@@ -78,6 +78,11 @@ struct MockVersionedPortfileProvider : PortFileProvider::IVersionedPortfileProvi
         }
         return it2->second;
     }
+
+    virtual void load_all_control_files(std::map<std::string, const SourceControlFileLocation*>&) const override
+    {
+        Checks::unreachable(VCPKG_LINE_INFO);
+    }
 };
 
 using Versions::Constraint;
@@ -190,6 +195,11 @@ struct MockOverlayProvider : PortFileProvider::IOverlayProvider, Util::ResourceB
         return it->second;
     }
 
+    virtual void load_all_control_files(std::map<std::string, const SourceControlFileLocation*>&) const override
+    {
+        Checks::unreachable(VCPKG_LINE_INFO);
+    }
+
 private:
     std::map<std::string, SourceControlFileLocation, std::less<>> mappings;
 };