diff options
| -rw-r--r-- | ports/thrift/portfile.cmake | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ports/thrift/portfile.cmake b/ports/thrift/portfile.cmake index af66b4a57..8aec05cb7 100644 --- a/ports/thrift/portfile.cmake +++ b/ports/thrift/portfile.cmake @@ -5,6 +5,10 @@ if (VCPKG_LIBRARY_LINKAGE STREQUAL dynamic) set(VCPKG_LIBRARY_LINKAGE static) endif() +# As per Ben Craig thrift comment see https://issues.apache.org/jira/browse/THRIFT-1834 +# Currently, Thrift is designed to be packaged as a static library. As a static library, the consuming program / dll will only pull in the object files that it needs, so the per-binary size increase should be pretty small. +# Thrift isn't a very good candidate to become a dynamic library. No attempts are made to preserve binary compatibility, or to provide a C / COM-like interface to make binary compatibility easy. + vcpkg_find_acquire_program(WINFLEXBISON) vcpkg_from_github( |