aboutsummaryrefslogtreecommitdiff
path: root/scripts
AgeCommit message (Collapse)Author
2020-07-31[cmake] Add cmake port to test qt (#10770)Alexander Neumann
* [cmake] add port for qt testing * only add cmcldeps on windows * [cmake] cleanup and fix portfile for osx build * [cmake] more cleanup * move cmake to scripts/test_ports * add the overlay scripts/test_ports to ci
2020-07-31[vcpkg-ci] fix macos setup scripts (#12639)nicole mazzuca
* [vcpkg-ci] fix macos setup scripts * the disk feature is still experimental * fix Get-InstalledVirtualBoxExtensionPacks * use new bash install script for brew instead of old-style ruby
2020-07-31[vcpkg] Fix vcpkg_fixup_cmake_targets to work correctly on MinGW (#12104)Todor Prokopov
* [vcpkg] Fix vcpkg_fixup_cmake_targets to work correctly on MinGW * [akali] Bump version to test vcpkg_fixup_cmake_targets changes * Update ports/akali/CONTROL Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
2020-07-31[rsocket] Add new port (#11021)curoky
* [rsocket] Add new port * [rsocket] don't build in some window environment * [rsocket] add missing deps in CONTROL * [rsocket] add missing deps in CONTROL * [rsocket] remove some deprecated args * [rsocket] romove vcpkg_fail_port_install(ON_ARCH x64) * [rsocket] only support x64 architecture * [rsocket] upgrade to 2020.05.04.00 * [rsocket] add vcpkg_fail_port_install to portfile * [rsocket] Fix find dependencies * Update ports/rsocket/portfile.cmake * Update ports/rsocket/CONTROL Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
2020-07-31Fix android toolchain so it correctly adds -fPIC flag (#12097)Jamie Kydd
(cherry picked from commit 497fe8ab805bcafd2cb2abd538db8783f897f9ad)
2020-07-31[vcpkg_fixup_pkgconfig] Remove required in first find_program call for ↵Alexander Neumann
pkg-config (#12569) * Remove required in first find_program call * add usr/local/bin for mac * lets try without cellar and see if osx ci agrees
2020-07-31[qt5 components] Disable parallel build (#12529)Jack·Boos·Yu
* [qt5-imageformats] Disable parallel build * [ompl] Disable parallel configure * [qt5-connectivity] Disable parallel build * [qwt] Update hash * [qt5-location] Disable parallel build * Update ports/qwt/portfile.cmake * Update ports/qwt/portfile.cmake Co-authored-by: Robert Schumacher <roschuma@microsoft.com> * [qt5] change build method to vcpkg_execute_build_process * Add condition when there are some file conflicts Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-30[mpir] Fix build error if VCPKG_BUILD_TYPE is set as release or debug (#12514)NancyLi1013
* [mpir] Fix build error if VCPKG_BUILD_TYPE is set as release or debug * Update ci.baseline.txt * EOL LF for vcpkg.json * Update to use vcpkg_configure_make and vcpkg_install_make in UNIX
2020-07-30[libmodbus] Fix static linkage error (#12530)NancyLi1013
2020-07-30[mozjpeg] fix build (#12118)Clinton Ingram
* fix mozjpeg build * re-disable in CI baseline * fix static install * rename static libs, add pkgconfig fixup * update version string Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com> Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-30[marble] Add new port (#8628)ig-or
* KDE Marble library port * fix in port KDE Marble library * port KDE Marble library: switch to another version * vcpkg_fail_port_install added (since only Windows currently supported) * remove some comments * Update portfile * KDE Marble library port * fix in port KDE Marble library * port KDE Marble library: switch to another version * vcpkg_fail_port_install added (since only Windows currently supported) * remove some comments * Update portfile * small fix in KDE Marble library port * removed ON_LIBRARY_LINKAGE static, and ANDROID FREEBSD * [marble]Fix triplet judgment * [kde] Add x64-windows-static state to baseline * [marble] Re-add x64-windows-static state to baseline * marble port changed * marble profile.cmake small correction * marble: another tiny changes in a port file * marble: patch to move exe to tools * [marble] patch for another QT version * Update ports/marble/CONTROL * move dll files to bin folder (out of tools folder) Co-authored-by: Igor Sandler <isandler@topcon.com> Co-authored-by: Phoebe <v-phma@microsoft.com> Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com> Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
2020-07-30[vcpkg] EOL LF for ci.baseline.txt (#12513)Alexander Neumann
* define line endings for ci.baseline.txt * renormalize line endings to lf
2020-07-30fix issue #9228 : Add support to subgroups in gitlab (#9248)Ramadan Ahmed Ramadan
* fix issue #9228 : Add support to subgroups in gitlab * Update vcpkg_from_gitlab.cmake * Update vcpkg_from_gitlab.cmake
2020-07-29[vcpkg] Improve format check failure message (#12460)Jack·Boos·Yu
* [docs] Add format document * improve the error message * Check the error message * Finish test * restore file list
2020-07-29[libusb] Fix issue to support linux (#9561)Phoebe
* [libusb] support linux * Add Supports * Using vcpkg_configure_make instead * Revert to install headers in windows * Fix failures in libftd1 * Update treehopper * Add failed ports in ci baseline file * Revert to remove azure-kinect-sensor-sdk:x64-windows-static=fail in baseline file * Resolve conflicts Co-authored-by: PhoebeHui <v-phma@microsoft.com>
2020-07-28[vcpkg-acquire-msys] Install new keyring (#12467)emptyVoid
2020-07-27[opencv4] update to v4.3 (#11130)Stefano Sinigardi
* [opencv4] draft update to v4.3 * restore uwp patch * fix qt and ipp features * fix libepoxy and meson on osx * fix baseline, trigger a full rebuild due to meson tool changes * remove jpeg feature on windows due to a bug with MSVC * minor fixes for some features * ffmpeg x11 lib not required anymore on apple for downstream projects * small fixes for ogre and qt5 * remove a broken module * fix installation path * fix openexr which was broken and regressed opencv downstream projects * first round of ci passes * improve compatibility with android toolchain * [openexr] upgrade to v2.5.0 to fix regressions, might require fixes in dependent projects and might deserve its own PR * fix OpenEXR link for downstream projects * do not install unrequested features * fix compatibility with newer OpenEXR * [OpenCV3] update to v3.4.10 * fix openexr on windows, was creating symlinks that broke vcpkg * fix openexr wrapper * [openexr] cmake config files are installed into a lowered-case folder * remove mangled paths trying to fix android setup * disable dnn on android, fix mangled cmake config paths again * fix downstream CUDA dependency * fix compatibility with vs16.6 * remove from baseline ports now passing tests * [alembic] fixes for new openexr * fix baseline * [field3d] fixes for new openexr * [field3d] improve fixes, windows still unsupported despite what is said upstream * apply fixes required from review * add missing field3d patch * [field3d] disable mpi integration * [opencv2] remove cublas integration * [vtk] do not create libharu::libharu target if already existing * Update ports/opencv4/portfile.cmake Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * Update ports/opencv3/portfile.cmake Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * improve compatibility with newer CUDNN * [OpenCV3, OpenCV4] improve compatibility with CUDA 11 * [OpenCV2] improve compatibility with CUDA 11 * [field3d] regenerate patch ignoring space at eol * [vcpkg] Use SSH keys instead of password authentication when minting Linux scale sets (#11999) * [field3d] regenerate patch ignoring space at eol * [field3d] regenerate patch, again * [field3d] fixes for windows * [libass] fix regression * ci.baseline.txt update * [CUDA11] use FindCUDA from CMake 3.18 to ease transition later * re-bump vtk and ffmpeg, which were lost with merges from master * [OpenCV4] Halide feature is not broken anymore * [field3d] regenerate hdf5 patch * [OpenCV4] remove GTK features: it can be built only on *nix but GTK on vcpkg cannot be built on *nix systems... * merge ci.baseline.txt from master and fix field3d patch * remove rebuilding * restore vtk CONTROL file * update CONTROL files * Trigger rebuild * Update ports/freeimage/CONTROL * Update ports/freeimage/CONTROL * [opencv3/4] avoid tesseract dependency on uwp builds * [opencv] add missing module search Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
2020-07-24[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries (#11550)Alexander Neumann
* [vcpkg/scripts/pkgconfig] rewrite pkgconfig check for libraries. * [vcpkg/scripts/pkgconfig] fix more details. * [vcpkg/scripts/pkgconfig] smaller improvements * ws change to check functionallity of script for testing. * [vcpkg/scripts/pkgconfig] update to latest test version * Revert "ws change to check functionallity of script for testing." This reverts commit 26269e9e776009230777d9390465715f2ebac465. * [nettle] bump control for vcpkg_fixup_pkgconfig test * [gmp] rerun CI to create new *.pc files * [gmp/nettle] enable port debug * [vcpkg/script/pkgconfig] fix path conversion regex for CI * [CI|OSX] install pkg-config on osx * [gmp/nettle] disable port debug * [vcpkg/scripts/pkgconfig] update to latest version of x windows pr * [zlib] add pkgconfig file * [zstd] add fixup pkgconfig * [libpng] add pc file installation * [bzip2] install pc file and leave a TODO for somebody else ;) * [bzip2] bump control * [vcpkg/scripts/pkgconfig] skip checks if pkgconfig cannot be found. - small bugfix in ignore flags regex * retry zstd and zlib * [libpng] retry by adding dl and m to system libraries for osx * [libpng] add missing vcpkg_fixup_pkgconfig() * [vcpkg/scripts/pkgconfig] unset var if found. fixes checks for other configurations which will be always succesful otherwise * [libpng] bump control * [libpng] enable port debug to debug osx regression * ws change to retrigger osx ci and hopeing that it works * fix typo * [libpng] remove -lm flag on apple platforms * ws change to rerun some ports in ci for good measure after the merge with master * Re-trigger CI test * [zstd] add pkgconfig * [zstd] correct debug link * [vcpkg/script/pkgconfig] - add more search suffixes for static libs - add additional debug messages for debuging - fix unsetting of cache variables hiding issues with debug libraries - fixed pkgconfig fix in the debug case * [pcre] add pthread dependency to pcre * [protobuf] fix pkgconfig * include quotes around the prefix in the case the prefix path was quoted (fixes some regressions) add option NOT_STATIC_PKGCONFIG to run pkg-config without the --static argument * [ignition-msgs5] get rid of a dev warning * [apr] fix apr regression * [protobuf] fix protobuf regression * [sdl1] fix regression due to variable expansion of pkg-config. Use similar regex to the library removal for ignored flags. * [ignition] fix regression * remove changes of zlib portfile. * reset changes in osx ci pipeline * add DISABLE_PARALLEL_CONFIGURE Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com> Co-authored-by: Billy Robert O'Neal <bion@microsoft.com>
2020-07-23[vcpkg] Add initial s390x support (#12534)Andrei Lebedev
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
2020-07-18Build fix with MinGW GCC 9.2.0 (#12084)Cristian Adam
* Build fix with MinGW GCC 9.2.0 * Fix MinGW tripplets Fixes #12065 * clang-format * Fix unused read_symlink_implementation warning marked as error read_symlink_implementation was used only in copy_symlink_implementation when #if defined(_WIN32) && !VCPKG_USE_STD_FILESYSTEM was true. Removed the warning otherwise. Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
2020-07-15[vcpkg_configure_make] typo fix '_vcpkg_append_to_configure_environment' ↵Kevin Lu
(#12432)
2020-07-14[libb2] Add supports and install pkg-conifg on macOS VM (#12398)Phoebe
* [libb2] Add supports and install pkg-conifg on macOS VM * Add blank line to the end of the json file * vcpkg x-format-manifest --all * Remove failed ports in ci baseline file
2020-07-13[vcpkg] Fix iOS toolchain detection when using the iOS community triplets ↵alcroito
(#12361) * [vcpkg ios] Fix detection of iOS toolchain (#6003) Added mapping of CMAKE_SYSTEM_NAME == iOS to the bundled iOS toolchain file. This fixes the "Unable to determine toolchain to use for triplet arm64-ios with CMAKE_SYSTEM_NAME iOS" error. * [vcpkg ios] Set the CMake system processor for the simulator arches (#6003) So it's consistent for all architectures.
2020-07-13[vcpkg] Track hashes of cmake script helpers in consuming portfiles (#12254)ras0219
* [vcpkg] Track hashes of cmake script helpers in consuming portfiles * [vcpkg] Format * [vcpkg_find_acquire_program] Use cpkg_from_sourceforge for FLEX and BISON Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-13[vcpkg-ci] Always publish file lists (#12384)ras0219
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-13[vcpkg] Improve informational message for `--editable` while cleaning ↵ras0219
sources (#12366) * [vcpkg] Improve informational message for --editable while cleaning sources * [vcpkg] Update scripts/cmake/vcpkg_extract_source_archive_ex.cmake Co-authored-by: nicole mazzuca <mazzucan@outlook.com> Co-authored-by: Robert Schumacher <roschuma@microsoft.com> Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
2020-07-13[vcpkg] Enable binary caching by default (#12370)ras0219
* [vcpkg] Enable binary caching by default. Support `x-` migration. Fix passing multiple copies of single parameter arguments. * [vcpkg] Handle x- prefixes for general arguments * [vcpkg] Fix #12285 and improve documentation of default binary cache path * [vcpkg] Revert x- prefix homogenization for per-command arguments * [vcpkg] Only use accelerated compiler detection for Windows Desktop + Ninja. Improve breadcrumbs for users encountering issues. * [vcpkg] Fix compiler tracking not pre-downloading Ninja. Fix compiler tracking not looking in -err.log. * [vcpkg] Update toolsrc/src/vcpkg/binarycaching.cpp Co-authored-by: Billy O'Neal <bion@microsoft.com> * [vcpkg] Format Co-authored-by: Robert Schumacher <roschuma@microsoft.com> Co-authored-by: Billy O'Neal <bion@microsoft.com>
2020-07-13[vcpkg] Add a schema file for vcpkg.json (#12178)Edhebi
* Add a schema file for vcpkg.json * [vcpkg.schema.json] fix $ref fields Per json schema, having any other field in a `{ "$ref": ""}` object is invalid. * [vcpkg.schema.json] change case to reflect usage * [vcpkg.schema.json] check reserved names for identifiers * [vcpkg.schema.json] add an $id field * [vcpkg.schema.json] Apply suggestions from code review Co-authored-by: nicole mazzuca <mazzucan@outlook.com> * [vcpkg.schema.json] Apply suggestions from code review Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
2020-07-09[vcpkg] Move default binary cache from `$root/archives` to user-wide ↵ras0219
directory (#12256) * [vcpkg] Move default binary cache from `$root/archives` to user-wide directory Teach nuget/nugetconfig binary sources to use read/write. * [vcpkg] Reformat Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-09[kfr] Add new port (#8322)myd7349
* [kfr] Add new port * [kfr] Modernize and update to lastest * [kfr] Add features * [kfr] Fail fast on arm-uwp, arm64-windows * [kfr] Fail fast on linux
2020-07-09[vcpkg manifests] fix some issues (#12227)nicole mazzuca
Fixes #12190 Fixes #12208 Fixes #12234 Fixes #12286 Fixes #12315 Fixes #12186 Fixes #12331 Fixes googleapis/google-cloud-cpp#4487
2020-07-08[qt5] update qt to 5.15 and make ports depend on qt5-base[core]. (#11596)Alexander Neumann
* [qt5] update qt to 5.15 and make ports depend on qt5-base[core]. * [qt5] update and remove patches * [baseline] skip qt5-canvas3d due to deprecation * [qwt] update to 6.1.4 and fix build issues * [qt5-webengine] remove old patches * [qwt] fix static patch * [qt5-location] add a message that the port has a sprious failure * [qt5-webengine] fix filename of patch * [qt5-webengine] add build.patch (ci is probably fast than me in checking for more errors) * [qt5-winextras] depend on qt5-base[core] Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> * [qt5-base] update latest feature (latest=core) * [baseline] remove qt5-webengine for nonstatic windows since CI can handle it now * [qt5-base] make qt5-base fail to get logs. * [angle] include missing egl sources. * [qt5-base] patch egl detection logic. * [baseline] remove qt-x11extras:x64-linux=fail * [qt5-base] need to be explicit about xcb to build qt5-x11extras * [CI] add necessary system libraries to linux CI * [qt5-base] remove comment to retry on linux * [qt5-base] add static_init patch for MSVC * [qt5-base] refined workaround to not regress linux and osx due to * [paraview] remove unnecessary patches with newer qt versions * [vcpkg/baseline] add webengine back to skip * [vtk] fix missing include regression using patch from upstream * [vtk] fix patch * [qt5-base] replace with patch from upstream * [paraview] use hdf5 1.10 api. * [paraview] bump control * Add more packages to Linux machines. * [qt5-base] forgot to add the patch * Delete 6943.diff Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
2020-07-08[freerdp] Fix x64-osx triplet (#12037)Alexandro Sanchez
* [freerdp] Fix x64-osx triplet Signed-off-by: Alexandro Sanchez Bach <alexandro@phi.nz> * Update ports/freerdp/CONTROL * Update scripts/ci.baseline.txt * Update scripts/ci.baseline.txt * Update scripts/ci.baseline.txt * Update ports/freerdp/CONTROL Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
2020-07-08[vcpkg] Fix MSBuild regressions #12062 and #12086. (#12257)ras0219
This PR also renames the VcpkgUserTriplet MSBuild variable to VcpkgTriplet to minimize user confusion compared to previous practice and documentation. Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-08[vcpkg.targets] Fix #12292 regression with MSBuild targets (#12319)Robert Schumacher
2020-07-07[vcpkg.cmake] Support toolchains that set CMAKE_FIND_ROOT_PATH_MODE_* ↵Silvio Traversaro
variables to ONLY (#11753)
2020-07-07[pcre2] Update to 10.35 (#11754)Wolfgang Stöggl
- New upstream version 10.35 - Update patches: pcre2-10.35_fix-space.patch pcre2-10.35_fix-uwp.patch - Add patch: pcre2-10.35_fix_postfix_for_debug_Windows_builds.patch - Drop patch (fixed upstream): fix-arm64-config.patch - Since 10.35, pkgconfig files are created using CMake * fix debug suffix of pkgconfig files under Windows * add vcpkg_fixup_pkgconfig() - Remove bin and debug/bin in case of static build - Update ci.baseline.txt Remove "pcre2:arm-uwp=fail", because arm-uwp passes now Add "unicorn-lib:arm-uwp=fail"
2020-07-07[vcpkg ci] Update formatting CI (#12314)nicole mazzuca
* stage checking formatting this means that the port CI won't run if the formatting failed * fix invalid names * add formatting of manifests * fix dependsOn name * fix a thing * CRs * oops, typo
2020-07-07[evpp] Fix build error on OSX (#11967)Jack·Boos·Yu
* [evpp] Fix build error on OSX * update baseline
2020-07-07[simdjson] Update to 0.4.6 (#12140)myd7349
* [simdjson] Update to 0.4.1 * [simdjson] Update to v0.4.2 * [simdjson] arm-uwp is supported now * Update scripts/ci.baseline.txt * [simdjson] x86 is also supported now(though not recommended) * [simdjson] Update to 0.4.3 (it will fail) * [simdjson] Disable Ninja temporarily * [simdjson] Update to 0.4.4 * [simdjson] Update to 0.4.5 * [simdjson] Add manifest file * [simdjson] Update to 0.4.6 * Update ports/simdjson/portfile.cmake Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
2020-07-07[vcpkg] Implement --editable (#12200)ras0219
--editable suppresses binary caching and source re-extraction for packages listed on the command line (similar to --head). This fundamentally changes the port maintenance loop, so several example documents were updated. To avoid users having substantial changes suddenly destroyed by forgetting to pass --editable, "clean" sources have different extract locations. The undocumented command `build` implies `--editable`. Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
2020-07-07[libbson, vcpkg baseline] Remove passing and fix spurious failure. (#12300)Billy O'Neal
* [libbson] DISABLE_PARALLEL_CONFIGURE * [vcpkg baseline] Fix 'passing, remove from baseline' in CI from 20200705.1 See https://dev.azure.com/vcpkg/public/_build/results?buildId=39820
2020-07-06[vcpkg] Format the C++ in CI (#11655)nicole mazzuca
* [vcpkg] Format the C++ in the CI * format the C++ * CR
2020-07-06[vcpkg] Add mingw dynamic libs triplet (#12101)Long Nguyen
* Update .gitignore * Add mingw dynamic lib triplets * Only copy pdbs if not using *-mingw triplets * Using VCPKG_POLICY_DLLS_WITHOUT_LIBS as a workaround * Rename *-mingw to *-mingw-dynamic Co-authored-by: Billy Robert O'Neal <bion@microsoft.com>
2020-07-06[vcpkg] Added python script to generate all packages file list, added to ↵Leo Yao
azur… (#12177) * Added python script to generate all packages file list, added to azure pipeline to build at the end of the run * fixed an issue that causes some leading slashes were being removed * Header Database now includes hpp files for C++ header files * Changed Header Database to include all files under \include\ folder * Apply suggestions from code review, changing condition from eq to ne Co-authored-by: Billy O'Neal <bion@microsoft.com> * Update last condition from eq to ne Co-authored-by: Billy O'Neal <bion@microsoft.com>
2020-07-06[openvr] Update to 1.12.5 (#12219)Rémy Tassoux
* [openvr] Update to 1.12.5 https://github.com/ValveSoftware/openvr/releases/tag/v1.12.5 * [openvr] Fix static build faillure * [openvr] revert aa222ad9f8fdc040dc5929138d9ed3c09ca215cd * [openvr] update ci.baseline.txt
2020-07-06[opengl wincrypt winsock2] Use $ENV{WindowsSdkDir} instead of hard coding ↵Billy O'Neal
Windows SDK paths. (#12232) Also delete vcpkg_get_program_files_32_bit because it was used in only one place. Resolves #8288 Obsoletes #11421, #11261, #8329
2020-07-05[vcpkg integrate] Clean up vcpkg.target file (#4608)Dr. Frank Heimes
Use IncludePath and LibraryPath propertiesThese tool agnostic properties allow to configure ClCompile and ResourceCompile without repeating the code. This change includes my changes from #4454. Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>
2020-07-03[vcpkg_from_sourceforge] Add retry mirror function (2/2) (#12018)Jack·Boos·Yu
2020-07-02[vcpkg] Remove the tombstones and 'ignore' baseline concepts. (#12197)Billy O'Neal
This changes our PR builds to treat 'fail' in the ci.baseline.txt as 'skip' instead of using tombstones. We currently have large numbers of spurious failures that get enshrined in PRs through no fault of a PR author, removing the tombstones concept will fix those by allowing the user to retry. This does mean we accept some risk of not detecting when a port is 'fixed', but that failure is reasonable for us to handle after we see it in CI, but that seems worth it given that it lets us get rid of the tombstone concept. This also helps out the binary caching feature, because we don't have to figure out how to productize tombstones.