From 66169e3f0d5f69a853c5f5c9d9c78af04d47ddfd Mon Sep 17 00:00:00 2001 From: Norbert Nemec Date: Mon, 3 Jun 2019 15:02:21 +0200 Subject: [glibmm] Rephrase comment --- ports/glibmm/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ports/glibmm/CMakeLists.txt b/ports/glibmm/CMakeLists.txt index 389ae8dfb..d48d9261b 100644 --- a/ports/glibmm/CMakeLists.txt +++ b/ports/glibmm/CMakeLists.txt @@ -40,9 +40,9 @@ if(APPLE) link_libraries(${COREFOUNDATION_LIBRARY} ${CORESERVICES_LIBRARY} ${FOUNDATION_LIBRARY}) endif() -# A hacky solution for building Windows DLLs from sources ported from Linux. -# The cleaner approach would be to manually add __declspec(dllexport) to all public symbols in the header files or -# construct a .def file. +# Activate workaround for exporting all symbols from Windows DLLs to mimic the +# behavior on Linux, where dynamic libraries always export all symbols. +# The same approach was already used by the upstream MSVC build (see MSVC_NMake/gendef/gendef.cc) set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS TRUE) if(BUILD_SHARED_LIBS) -- cgit v1.2.3