From f7dcd675d08f7a6974893e592e2aee0b7c318bb0 Mon Sep 17 00:00:00 2001 From: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com> Date: Sat, 1 Aug 2020 22:48:12 +0200 Subject: [qt-webengine] Fix building with vs2017 (#12494) * [qt5-webengine] fix vs2017 builds. closes #12477 * remove skip from ci baseline to test changes. * add src/3rdparty/ subdir to patch * put webengine back to skip. patch was succesfully applied --- scripts/ci.baseline.txt | 1 + 1 file changed, 1 insertion(+) (limited to 'scripts') diff --git a/scripts/ci.baseline.txt b/scripts/ci.baseline.txt index c4a4fb370..07dd2428d 100644 --- a/scripts/ci.baseline.txt +++ b/scripts/ci.baseline.txt @@ -1451,6 +1451,7 @@ qt5-webengine:x64-osx=fail # Fail due to outdated protoc headers. # D:\buildtrees\qt5-webengine\x64-windows-dbg\src\core\debug\gen\net/third_party/quiche/src/quic/core/proto/cached_network_parameters.pb.h(17): # fatal error C1189: #error: This file was generated by an older version of protoc which is +# Succesful built requires protobuf to be installed after qt5-webengine not before. Otherwise the build picks up the wrong headers from inside vcpkg. qt5-webengine:x64-windows=skip qt5-webengine:x86-windows=skip # Static builds of qt5-webengine are not supported by the port itself -- cgit v1.2.3