diff options
| author | Even Rouault <even.rouault@spatialys.com> | 2019-04-14 20:11:17 +0200 |
|---|---|---|
| committer | Even Rouault <even.rouault@spatialys.com> | 2019-04-14 22:39:26 +0200 |
| commit | 47db7804524066e74fd787bdd0d7f2ba8394c220 (patch) | |
| tree | 08eec28f254291186c8256265cc0034555ec02af | |
| parent | 85b564a5b1096274752c4c50640a509f51fca214 (diff) | |
| download | PROJ-47db7804524066e74fd787bdd0d7f2ba8394c220.tar.gz PROJ-47db7804524066e74fd787bdd0d7f2ba8394c220.zip | |
lcc: avoid division by zero
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14250
Credit to OSS Fuzz
| -rw-r--r-- | src/projections/lcc.cpp | 7 | ||||
| -rw-r--r-- | test/gie/builtins.gie | 11 |
2 files changed, 16 insertions, 2 deletions
diff --git a/src/projections/lcc.cpp b/src/projections/lcc.cpp index aca025be..a101009d 100644 --- a/src/projections/lcc.cpp +++ b/src/projections/lcc.cpp @@ -121,7 +121,12 @@ PJ *PROJECTION(lcc) { if( ml2 == 0 ) { return pj_default_destructor(P, PJD_ERR_LAT_1_OR_2_ZERO_OR_90); } - Q->n /= log(ml1 / ml2); + const double denom = log(ml1 / ml2); + if( denom == 0 ) { + // Not quite, but es is very close to 1... + return pj_default_destructor(P, PJD_ERR_INVALID_ECCENTRICITY); + } + Q->n /= denom; } Q->c = (Q->rho0 = m1 * pow(ml1, -Q->n) / Q->n); Q->rho0 *= (fabs(fabs(P->phi0) - M_HALFPI) < EPS10) ? 0. : diff --git a/test/gie/builtins.gie b/test/gie/builtins.gie index 7de5fccc..8e82979e 100644 --- a/test/gie/builtins.gie +++ b/test/gie/builtins.gie @@ -2740,10 +2740,19 @@ expect 1 2 ------------------------------------------------------------------------------- operation +proj=lcc +a=9999999 +b=.9 +lat_2=1 -------------------------------------------------------------------------- +------------------------------------------------------------------------------- expect failure errno invalid_eccentricity ------------------------------------------------------------------------------- +# This case is incredible. ossfuzz has found the exact value of lat_1 that +# triggers a division by zero +operation +proj=lcc +lat_1=2D32 +lat_2=0 +a=6378137 +b=0.2 +------------------------------------------------------------------------------- +expect failure +# For some reason fails on MacOSX with a different error +# errno invalid_eccentricity + +------------------------------------------------------------------------------- operation +proj=lcc +ellps=GRS80 +lat_1=0 +lat_2=90 ------------------------------------------------------------------------------- expect failure errno lat_1_or_2_zero_or_90 |