Declare non-local variables as const where possible

Having non-const variables of static lifetime or even global scope is
usually a bad idea. These variables are inherently constants, and this
should be enforced.

This required marking some functions as not modifying input parameters
and marking some pointers as pointers to const.

One advantage is that the compiler usually puts const static variables
in a read-only code segment, so they can't be modified physically.
This can be verified with `nm` (on POSIX systems).

To avoid changes to the public API, functions returning non-const
pointers to data tables were left intact, but the returned data may not
be modified. Internally we prefer using the proj_list_* functions over
the pj_get_*_ref functions, because the former return const pointers.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/proj_internal.h b/src/proj_internal.h
index 6571bce9..13a1cac6 100644
--- a/src/proj_internal.h
+++ b/src/proj_internal.h
@@ -119,7 +119,7 @@ char  *pj_make_args (size_t argc, char **argv);
 /* Lowest level: Minimum support for fileapi */
 void proj_fileapi_set (PJ *P, void *fileapi);
 
-const char **proj_get_searchpath(void);
+const char * const *proj_get_searchpath(void);
 int    proj_get_path_count(void);
 
 size_t pj_strlcpy(char *dst, const char *src, size_t siz);