aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordef <dennis@felsin9.de>2016-06-09 21:38:20 +0200
committerdef <dennis@felsin9.de>2016-06-09 21:38:20 +0200
commit4d697d9fc6a0a23fe3e448aed0ad8d5ea2a93b9a (patch)
tree2a86af34eeccdacbeac77716dab6be76f789ea64
parent6d91cfad043d233a1726a26ba24fb292fac90b74 (diff)
downloadpackages-4d697d9fc6a0a23fe3e448aed0ad8d5ea2a93b9a.tar.gz
packages-4d697d9fc6a0a23fe3e448aed0ad8d5ea2a93b9a.zip
Add check for git://github.com URLs
-rw-r--r--package_scanner.nim7
1 files changed, 6 insertions, 1 deletions
diff --git a/package_scanner.nim b/package_scanner.nim
index a41fde0..e66417f 100644
--- a/package_scanner.nim
+++ b/package_scanner.nim
@@ -10,6 +10,7 @@
# * Missing tags
# * Missing description
# * Missing/unknown license
+# * Insecure git:// url on GitHub
#
# Usage: nim c -d:ssl -r package_scanner.nim
#
@@ -101,7 +102,7 @@ proc check(): int =
echo "E: ", name, " has no URL"
result.inc()
- elif not canFetchNimbleRepository(name, pdata["web"]):
+ elif pdata.hasKey("web") and not canFetchNimbleRepository(name, pdata["web"]):
result.inc()
elif not pdata.hasKey("tags"):
@@ -116,6 +117,10 @@ proc check(): int =
echo "E: ", name, " has no license"
result.inc()
+ elif pdata["url"].str.normalize.startsWith("git://github.com/"):
+ echo "E: ", name, " has an insecure git:// URL instead of https://"
+ result.inc()
+
else:
# Other warnings should go here
if not (pdata["license"].str in LICENSES):